RUI race condition fix #1101
Merged
RUI race condition fix #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axdanbol
requested changes
Sep 11, 2023
| filterNulls(), | ||
| tap(reg => this.editRegistration(reg as SpatialEntityJsonLd)) | ||
| ).subscribe(); | ||
| this.refData.getSourceDB().subscribe(db => { |
There was a problem hiding this comment.
I think this may cause the database to be loaded twice. Instead listen to the refData state (or part of it) and then subscribe to that.
| tap(reg => this.editRegistration(reg as SpatialEntityJsonLd)) | ||
| ).subscribe(); | ||
| this.refData.getSourceDB().subscribe(db => { | ||
| this.refData.setState(db); |
There was a problem hiding this comment.
Already done in the reference data state
|
Kudos, SonarCloud Quality Gate passed! |
axdanbol
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a fix to resolve the race condition issue in #1089
The unwanted registration popup issue comes up when there is a large delay between DOMContentLoaded and populating the values in the ccf-rui element. The workaround for now is to inject the element after updating the values (see webcomponent-async-inject-example.html).